On 02/10/2013 13:06, Brian Burch wrote: > On 02/10/13 12:27, Mark Thomas wrote: >> On 02/10/2013 12:23, Brian Burch wrote: >>> On 02/10/13 09:21, Mark Thomas wrote: >>>> On 01/10/2013 22:56, Konstantin Preißer wrote: >>>>> Hi Mark, >>>>> >>>>>> -----Original Message----- >>>>>> From: Mark Thomas [mailto:ma...@apache.org] >>>>>> Sent: Tuesday, October 1, 2013 8:39 PM >>>>>> To: Tomcat Developers List >>>>>> Subject: 8.0.x / 7.0.x progress >>>>>> >>>>>> Pulling together information from multiple threads: >>>>>> >>>>>> 8.0.x trunk appears to be stable (i.e. no longer crashes) but the >>>>>> FormAuthenticator unit tests are very slow (24 minutes). This >>>>>> needs to >>>>>> be resolved. >>>>> >>>>> I noticed something strange with the Snake WebSocket example when >>>>> running current trunk (r1528211) on Windows (x64) with 64-bit version >>>>> of tcnative-1.dll (version 1.1.29 - from Mladen: >>>>> http://people.apache.org/~mturk/native/tomcat-native-win32-x86_64-r1528132.zip). >>>>> >>>>> >>>> >>>> I've noticed a number of oddities as well. Fixing these is next on my >>>> TODO list in case they highlight further issues with the APR/native >>>> connector. >>> >>> When I did some work on this class, I remember discussing how one or two >>> of the FormAuthenticator test cases took a while to run because they >>> have to wait for a timeout, but I haven't paid attention to run-times >>> recently. >>> >>> I have a current and also a 3-week old version of tc8 trunk, and both >>> TestFormAuthenticator runs take over 4 minutes - I don't remember them >>> taking that long. >>> >>> However, I am running my tests ONLY under nio... both apr and bio are >>> disabled in my build.properties. >>> >>> If you want me to take a look, let me know. On the other hand, if you >>> think it is caused by your recent changes, I'll leave it alone for now. >> >> Thanks for the offer. The problem was caused by my changes and should >> now be fixed providing a native library from 1.1.x trunk is used. > > I just updated to r1528436, verified build.properties.default was > pointing to tomcat-native-1.1.28 and not over-ridden by > build.properties. I ran a clean, build and run of TestFormAuthenticator > under nio only... still 4 minutes. > > testTimoutWithCookies is expected to take a long time, but 73 secs seems > too long for me.
I'd expect that with APR and 1.1.28 rather than the latest code from the 1.1.x branch. NIO I'd expect to be a lot faster. > I intend to revisit these authenticator test suites soon for a clean-up, > so I'll see whether I can reduce the run times without making them more > complicated than necessary. Anything that speeds up the unit tests is always welcome. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
