Christopher, On Mon, Aug 26, 2013 at 3:32 PM, Christopher Schultz < ch...@christopherschultz.net> wrote:
> Larry, > > On 8/26/13 4:10 PM, Larry Shatzer, Jr. wrote: > > I was playing around with making the manager page look a bit more modern. > > (I see bug 55383, which is kinda related)... > > > > I whipped up a proof of concept with a static HTML page, using > Bootstrap. I > > put it up on github, if anyone wanted to take a look: > > https://github.com/larrys/tomcat-manager-bootstrap > > > > I'm not a bootstrap/css guy, and just copied an example bootstrap > template, > > and some of the areas on the page need a bit of work. I just wanted to > get > > a quick proof of concept, and solicet feedback before I spent a lot of > time > > on it. > > Would you be willing to produce some patches for Tomcat? (Either that or > teach me how to take stuff from github and apply it to Tomcat sources). > Note that the manager application really should not have any external > dependencies (e.g. Bootstrap source files loaded remotely) so we may > need to include some of their sources (yay! AL2.0!), or structure things > so that they look okay out of the box, but great if you install the > Bootstrap stuff yourself. The reason we can't just refer to > twitter.com/bootstrap/main.js (or whatever) is because not everyone > exposes their Tomcat installation to the Internet. > > I'm not opposed to distilling the sample HTML code I provided into the HTMLManager servlet, if that is a direction that is desirable. If you just wanted to look at the proof of concept, you can download a zip of it, and just load the index.html in a browser. ( https://github.com/larrys/tomcat-manager-bootstrap/archive/master.zip) It is just a standalone HTML page that represents what I think one possible update to the manager GUI could be, using bootstrap. I wanted to avoid changing code, and have a quicker feedback cycle on the look and feel in just static HTML. I also never intended to have it load an external resource for Bootstrap stuff. > > I was also wondering if there was a reason why the manager servlet has > the > > HTML inlined in the Java code, instead of using JSPs? > > As dumb as it sounds this was probably done to limit the number of > moving parts in the manager application. IMHO, the manager application > (nay, all Tomcat-bundled applications) should be an example of clean > design and implementation using the appropriate technologies at hand. > > I think updating the look and feel should be done outside of any switch to use JSP, to keep the two changes somewhat independent. Maybe switching the manager application to use JSP for all presentation, while still using the servlets below for the heavy lifting of deploying, should be done first. Then updating the look and feel should be easier. -- Larry
