On Aug 12, 2013, at 8:16 AM, Mark Thomas <ma...@apache.org> wrote: > On 09/08/2013 07:21, jboy...@apache.org wrote: >> Author: jboynes >> Date: Fri Aug 9 06:21:56 2013 >> New Revision: 1512148 >> >> URL: http://svn.apache.org/r1512148 >> Log: >> Start adding model for loading complete TLDs using Digester. >> This will unify Jasper's model, which is mostly complete but uses a separate >> DOM model, >> and Catalina's, which is Digester based but only handles listener entries. > > <snip/> > >> Added: tomcat/trunk/java/org/apache/tomcat/util/descriptor/tld/Tag.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/descriptor/tld/Tag.java?rev=1512148&view=auto >> ============================================================================== >> --- tomcat/trunk/java/org/apache/tomcat/util/descriptor/tld/Tag.java (added) >> +++ tomcat/trunk/java/org/apache/tomcat/util/descriptor/tld/Tag.java Fri Aug >> 9 06:21:56 2013 > > <snip/> > >> + private List<Variable> variables; >> + private List<Attribute> attributes; > > These two are still showing as unused but from the commit messages I'd > expect them to be used.
I'm not quite finished with loading the full descriptors. These were not needed for the listener processing but will be needed for the next step where we use them within Jasper. I needed to pause to consider the memory concurrency issues as whilst the listener code is single threaded, the translation side can be access by multiple threads. I wanted to checkpoint what I'd been able to finish this weekend rather than sit on it for another week and have a bigger commit. Thanks Jeremy
signature.asc
Description: Message signed with OpenPGP using GPGMail
