Hi Mark, On 06.08.2013 21:52, Mark Thomas wrote: > Rainer (or anyone else that can figure this out), > > I am in the process of fixing [1] and find myself having to revert some > of one of your commits [2]. My concern is that I can't figure out what > problem [2] was meant to solve and how it solves it. > > The problem is that the WsSessionListener does not have a zero-arg > constructor. There is a statement in Servlet 3.1 section 11.3.1 that > indicates that it should, be that looks to be out-dated and aimed at > web.xml configuration (where a zero arg constructor is obviously required). > > Mark > > [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=55365 > [2] http://svn.apache.org/viewvc?view=revision&revision=932969
My mailbox archeology shows that the change happened during one of the Retreats in Knockree. It was in preparation of TC 7.0.0 RC 1 (funny now that we are at 8.0.0 RC 1). As I normally do not test with the security manager I'm pretty sure we were hanging around and talked about preparing the release and fixing security manager problems. There are also a couple of commits to the PMC repos during that days. I sent a first draft of the patch to Jean-Frederic at 1 in the morning and an update at 5 in the morning about security manager TCK results after applying the patch. Finally I did commit this patch plus some trivial ones later during the day. Upshot: the patch was simply intended to fix security manager TCK failures for TC 7 at the time. So feel free to revert or improve any wrong parts. For completeness I checked out r932968 and am now running the TCK under security manager. I'll report the original failures that the patch should have fixed later on Wednesday. Regards, Rainer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
