Author: markt Date: Sun Jul 14 11:50:52 2013 New Revision: 1502960 URL: http://svn.apache.org/r1502960 Log: Implement the Set construction syntax. Includes the initial unit tests for this syntax.
Added: tomcat/trunk/test/org/apache/el/parser/TestAstSetData.java (with props) Modified: tomcat/trunk/java/org/apache/el/parser/AstSetData.java Modified: tomcat/trunk/java/org/apache/el/parser/AstSetData.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/parser/AstSetData.java?rev=1502960&r1=1502959&r2=1502960&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/el/parser/AstSetData.java (original) +++ tomcat/trunk/java/org/apache/el/parser/AstSetData.java Sun Jul 14 11:50:52 2013 @@ -17,10 +17,35 @@ /* Generated By:JJTree: Do not edit this line. AstSetData.java Version 4.3 */ package org.apache.el.parser; -public -class AstSetData extends SimpleNode { - public AstSetData(int id) { - super(id); - } +import java.util.HashSet; +import java.util.Set; + +import javax.el.ELException; + +import org.apache.el.lang.EvaluationContext; + +public class AstSetData extends SimpleNode { + + public AstSetData(int id) { + super(id); + } + + @Override + public Object getValue(EvaluationContext ctx) throws ELException { + Set<Object> result = new HashSet<>(); + + if (children != null) { + for (Node child : children) { + result.add(child.getValue(ctx)); + } + } + + return result; + } + + @Override + public Class<?> getType(EvaluationContext ctx) throws ELException { + return Set.class; + } } /* JavaCC - OriginalChecksum=e1dc4e2011eee313491decfa9e0152fe (do not edit this line) */ Added: tomcat/trunk/test/org/apache/el/parser/TestAstSetData.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/el/parser/TestAstSetData.java?rev=1502960&view=auto ============================================================================== --- tomcat/trunk/test/org/apache/el/parser/TestAstSetData.java (added) +++ tomcat/trunk/test/org/apache/el/parser/TestAstSetData.java Sun Jul 14 11:50:52 2013 @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.el.parser; + +import java.util.Collections; +import java.util.HashSet; +import java.util.Set; + +import javax.el.ELContext; +import javax.el.ELManager; +import javax.el.ELProcessor; +import javax.el.ExpressionFactory; +import javax.el.ValueExpression; + +import org.junit.Assert; +import org.junit.Test; + +public class TestAstSetData { + + private static final Set<String> simpleSet = new HashSet<>(); + private static final Set<Object> nestedSet = new HashSet<>(); + + static { + simpleSet.add("a"); + simpleSet.add("b"); + simpleSet.add("c"); + + nestedSet.add(simpleSet); + nestedSet.add(Collections.EMPTY_SET); + nestedSet.add("d"); + } + + + @Test + public void testSimple01() { + ELProcessor processor = new ELProcessor(); + Object result = processor.getValue("{'a','b','c'}", Set.class); + Assert.assertEquals(simpleSet, result); + } + + + @Test + public void testSimple02() { + ELProcessor processor = new ELProcessor(); + Object result = processor.getValue("{}", Set.class); + Assert.assertEquals(Collections.EMPTY_SET, result); + } + + + @Test + public void testNested01() { + ELProcessor processor = new ELProcessor(); + Object result = processor.getValue("{{'a','b','c'},{},'d'}", Set.class); + Assert.assertEquals(nestedSet, result); + } + + + @Test + public void testGetType() { + ELProcessor processor = new ELProcessor(); + ELContext context = processor.getELManager().getELContext(); + ExpressionFactory factory = ELManager.getExpressionFactory(); + + ValueExpression ve = factory.createValueExpression( + context, "${{'a','b','c'}}", Set.class); + + Assert.assertEquals(Set.class, ve.getType(context)); + Assert.assertEquals(simpleSet, ve.getValue(context)); + } +} Propchange: tomcat/trunk/test/org/apache/el/parser/TestAstSetData.java ------------------------------------------------------------------------------ svn:eol-style = native --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org