https://issues.apache.org/bugzilla/show_bug.cgi?id=51813
--- Comment #8 from Rainer Jung <rainer.j...@kippdata.de> --- (In reply to Christopher Schultz from comment #7) > Created attachment 30402 [details] > Patch against tcnative-1.1.x > > I'm not sure if I should be checking s->net or s->sock. They both seem to be > set to NULL in the various recycle routines so it probably doesn't matter > either way. I'd go with the net member and add the check to and function of name send* and recv*, which already have the null pointer check for s (or its jlong equivalent sock). > I'm also not sure if APR_EINVALSOCK is the right error code to use. * APR_EINVALSOCK APR was given an invalid socket * APR_ENOSOCKET APR was not given a socket So APR_EINVALSOCK sounds good. I haven't though checked the code that calls the recv* and send* methods for special error handling. Regards, Rainer -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
