2013/5/25 Mark Thomas wrote: > > On 25/05/2013 08:04, Violeta Georgieva wrote: > > 2013/5/25 Mark Thomas wrote: > >> > >> On 24/05/2013 21:58, violet...@apache.org wrote: > >>> Author: violetagg > >>> Date: Fri May 24 20:58:10 2013 > >>> New Revision: 1486217 > >>> > >>> URL: http://svn.apache.org/r1486217 > >>> Log: > >>> Temporary disable the test check. > >> > >> Why? > > > > Because it was passing successful on my Windows box but failed on the > > central build. > > > >> And why does this need to be in svn rather than a local change? > > > > Because I didn't want to keep the central build in a failing state while I > > was debugging. > > Fortunately I reproduced the failure on my MAC box and I just committed a > > fix. > > Thanks for the explanation. It is usually worth putting brief details of > the why for stuff like this in the commit message.
Sure I'll do it in the future Thanks Violeta > For example, I knew > about the failure but hadn't looked into the why (we still get some > random failures we don't fully understand) so the need for this wasn't > clear to me. > > Mark > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
