2013/3/15  <ma...@apache.org>:
> Author: markt
> Date: Fri Mar 15 14:42:47 2013
> New Revision: 1456970
>
> URL: http://svn.apache.org/r1456970
> Log:
> Expose new rotate method via JMX
>
> Modified:
>     tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
>
> Modified: tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml?rev=1456970&r1=1456969&r2=1456970&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml 
> (original)
> +++ tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml Fri 
> Mar 15 14:42:47 2013
> @@ -109,6 +109,12 @@
>                 type="java.lang.String"/>
>
>      <operation name="rotate"
> +               description="Check if the log file is due to be rotated and 
> rotate if it is"
> +               impact="ACTION"
> +               returnType="void">
> +    </operation>
> +
> +    <operation name="rotate"
>                 description="Move the existing log file to a new name"
>                 impact="ACTION"
>                 returnType="boolean">
> @@ -267,6 +273,12 @@
>                 type="java.lang.String"/>
>
>      <operation name="rotate"
> +               description="Check if the log file is due to be rotated and 
> rotate if it is"
> +               impact="ACTION"
> +               returnType="void">
> +    </operation>
> +
> +    <operation name="rotate"
>                 description="Move the existing log file to a new name"
>                 impact="ACTION"
>                 returnType="boolean">
>
>
>

It seems to define duplicated rotate operations  in AccessLogValve's
MBean descripter.
I think that o.a.t.util.modeler.ManagedBean does not support method overload.

=== ManagedBean#addOperation
public void addOperation(OperationInfo operation) {
    operations.put(operation.getName(), operation);
}
====

Maybe need to change name of rotate method.


-- 
Keiichi.Fujino

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to