https://issues.apache.org/bugzilla/show_bug.cgi?id=54693
Christopher Schultz <ch...@christopherschultz.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #2 from Christopher Schultz <ch...@christopherschultz.net> ---
Only one comment: since a value of "0" disabled query timeout (it will wait
forever), why not make the default 0 instead of -1?
Also, you mention that QueryTimeoutInterceptor will modify the query timeouts
of all queries... how does it interact with this patch? Will
QueryTimeoutInterceptor set the query timeout and then your code re-sets the
query timeout (presumably to a different value)? If that's the case, what
happens when validationQueryTimeout=0 and you are using the
QueryTimeoutInterceptor? A reasonable user might expect that the validation
query would /never/ time out, but the QueryTimeoutInterceptor would affect it.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
