Author: markt Date: Fri Mar 15 09:18:04 2013 New Revision: 1456822 URL: http://svn.apache.org/r1456822 Log: Merge upadtes from Commons FileUpload prior to code re-org
Modified: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/ (props changed) tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileItem.java tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileItemHeaders.java tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java Propchange: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/ ------------------------------------------------------------------------------ Merged /commons/proper/fileupload/trunk/src/java/org/apache/commons/fileupload:r964209-1445523 Modified: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileItem.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileItem.java?rev=1456822&r1=1456821&r2=1456822&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileItem.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileItem.java Fri Mar 15 09:18:04 2013 @@ -50,7 +50,7 @@ import java.io.UnsupportedEncodingExcept * * @version $Id$ */ -public interface FileItem extends Serializable { +public interface FileItem extends Serializable, FileItemHeadersSupport { // ------------------------------- Methods from javax.activation.DataSource Modified: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileItemHeaders.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileItemHeaders.java?rev=1456822&r1=1456821&r2=1456822&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileItemHeaders.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileItemHeaders.java Fri Mar 15 09:18:04 2013 @@ -44,34 +44,29 @@ public interface FileItemHeaders { /** * <p> * Returns all the values of the specified item header as an - * <code>Enumeration</code> of <code>String</code> objects. + * <code>Iterator</code> of <code>String</code> objects. * </p> * <p> * If the item did not include any headers of the specified name, this - * method returns an empty <code>Enumeration</code>. The header name is + * method returns an empty <code>Iterator</code>. The header name is * case insensitive. * </p> * * @param name a <code>String</code> specifying the header name - * @return an <code>Enumeration</code> containing the values of the + * @return an <code>Iterator</code> containing the values of the * requested header. If the item does not have any headers of - * that name, return an empty <code>Enumeration</code> + * that name, return an empty <code>Iterator</code> */ Iterator<String> getHeaders(String name); /** * <p> - * Returns an <code>Enumeration</code> of all the header names. - * </p> - * <p> - * If the item did not include any headers of the specified name, this - * method returns an empty <code>Enumeration</code>. The header name is - * case insensitive. + * Returns an <code>Iterator</code> of all the header names. * </p> * - * @return an <code>Enumeration</code> containing the values of the - * requested header. If the item does not have any headers of - * that name return an empty <code>Enumeration</code> + * @return an <code>Iterator</code> containing all of the names of + * headers provided with this file item. If the item does not have + * any headers return an empty <code>Iterator</code> */ Iterator<String> getHeaderNames(); } Modified: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java?rev=1456822&r1=1456821&r2=1456822&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java Fri Mar 15 09:18:04 2013 @@ -327,7 +327,7 @@ public abstract class FileUploadBase { } if (fileItem instanceof FileItemHeadersSupport) { final FileItemHeaders fih = item.getHeaders(); - ((FileItemHeadersSupport) fileItem).setHeaders(fih); + fileItem.setHeaders(fih); } } successful = true; Modified: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java?rev=1456822&r1=1456821&r2=1456822&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java Fri Mar 15 09:18:04 2013 @@ -33,7 +33,6 @@ import java.util.Map; import org.apache.tomcat.util.http.fileupload.DeferredFileOutputStream; import org.apache.tomcat.util.http.fileupload.FileItem; import org.apache.tomcat.util.http.fileupload.FileItemHeaders; -import org.apache.tomcat.util.http.fileupload.FileItemHeadersSupport; import org.apache.tomcat.util.http.fileupload.FileUploadException; import org.apache.tomcat.util.http.fileupload.IOUtils; import org.apache.tomcat.util.http.fileupload.ParameterParser; @@ -80,7 +79,7 @@ import org.apache.tomcat.util.http.fileu * @version $Id$ */ public class DiskFileItem - implements FileItem, FileItemHeadersSupport { + implements FileItem { // ----------------------------------------------------- Manifest constants --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org