On 09/03/2013 23:03, Nick Williams wrote: > Mark, > > I noticed the HttpServletRequest upgrade method still had the > signature void upgrade(HttpUpgradeHandler) when it should be <T > extends HttpUpgradeHandler> T upgrade(Class<T>) per the latest spec. > What's your status on getting this changed?
Haven't even looked at it. > I started to try to clean > this up a bit (I can email you a partial patch that has compile > errors in WebSocketServlet and WsServlet to save you some time, if > you want), but I hit a road block with WsProtocolHandler, which is > going to need a zero-arg constructor. I stopped there to avoid > stepping on your toes. No need to worry about my toes. Go ahead and make the changes. The (off the top of my head) approach I suggest for WsProtocolHandler is change the current constructor to (I was going to say init) preInit() or any other better name you can thing of and throw an exception in init() if preInit hasn't been called by the time init() is called. That should work... If it doesn't feel free to refactor to get something that does. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
