On 14.02.2013 23:52, Mladen Turk wrote: > On 02/14/2013 12:42 AM, rj...@apache.org wrote: >> Author: rjung >> Date: Wed Feb 13 23:42:26 2013 >> New Revision: 1445989 >> >> URL: http://svn.apache.org/r1445989 >> Log: >> Minimum APR version is 1.3.0 since 1.1.25. >> PR 54559 >> > > I'm not happy with this patch. > It disables using 1.2.x completely, so please revert that. > We can just add my patch I send to Henry cause it'll allow > to work although it won't have the same speed as with 1.3.x and newer. > > This that would be a much better solution. > The entire 1.3 dependency was (like noted) unintentional, so > we should make it work again with 1.2.x
Done in r1446443. Note: the version check in jnilib.c wouldn't detect whether a build was done against 1.3.0+ and at runtime there's only 1.2.x. I don't know whether that leads to missing symbols or other problems. I refrained from writing the configure time apr version to a generated header file and then use that version during the runtime test: On Unix/Linux that should not happen because of the SONAME rules used by APR libs. Don't know whether the same is true for Windows. If "yes", then we don't have a problem, but I then don't understand the necessity for the runtime APR version check in jnilib.c ;) Regards, Rainer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
