2013/2/13 <ma...@apache.org>:
> Author: markt
> Date: Wed Feb 13 09:28:58 2013
> New Revision: 1445517
>
> URL: http://svn.apache.org/r1445517
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54552
> Servlet 3.1
> Implement HttpSessionIdListener and HttpServletRequest#changeSessionId()
> Patch provided by Nick Williams.
>
I think that this code itself is not a problem at all. (I think prety good.)
However I have a idea of code improvement.
There seems to be a duplicate code on ManagerBase and DeltaManager.
e.g.
By introducing a following method to ManagerBase and DeltaManager,
we might be able to avoid code duplication.
==
changeSessionId(Session session, String newId)
changeSessionId(Session session, String newId,
boolean notifySessionListeners, boolean notifyContainerListeners)
==
And furthermore, we are changing sessionId in JvmRouteBinderValve.
Change sessionid of JvmRouteBinderValve is completely different from
Manager#changeSessionId.
By using new changeSessionId method, will be able to change sessionId
in a same way.
As a result, JvmRouteSessionIDBinderListener will be unnecessary.
I'm going to fix these improvements If there is no objections from anyone.
Any objections and comment?
--
Keiichi.Fujino
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
