Hi Konstantin,
On 12.02.2013 19:21, Konstantin Kolinko wrote:
> 2013/2/12 <rj...@apache.org>:
>> @Override
>> public void contextInitialized(ServletContextEvent sce) {
>> + super.contextInitialized(sce);
>
> Shoudn't the other two listeners changed by this commit call
> super.contextInitialized(sce);
> as well?
>
> a) TestWsWebSocketContainer.BlockingConfig
> b) TesterEchoServer.Config
>
> If not, maybe add a comment?
The code called by super.contextInitialized was not called in the
original version. So it is not strictly necessary. It seems the init of
the ServerContainerImpl for the context was already done before.
On the other hand all code called by super.contextInitialized is
currently idempotent, so I now decided that I find it more consistent to
call super.contextInitialized.
Added in r1445323, unit tests still suceed.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
