On 9 February 2013 09:42, Remy Maucherat <r...@apache.org> wrote: > On Sat, 2013-02-09 at 05:19 +0400, Konstantin Kolinko wrote: >> 2013/2/8 Konstantin Kolinko <knst.koli...@gmail.com>: >> > Hi! >> > >> > FYI, there are a lot of checkstyle errors in o.a.c.storeconfig package, >> > >> > a) tabs in server-registry.xml >> > b) a lot of trailing whitespace >> >> Fixed. > > Thanks ! > >> Further notices: >> 1. In a lot of places the code uses name "childs" instead of "children". >> >> E.g. childs="true" in server-registry.xml >> E.g. storeChilds(..) method in StoreFactoryBase class > > This probably didn't change from the initial revision of the component. > I guess I didn't event notice it (ahah). Is it worth fixing ? (probably) > >> 2. Javadoc for StoreLoader documents XML format for a registry file. >> >> What I see there is not what I see in server-registry.xml file in the >> storeconfig package. >> >> E.g. documented >> <TransientChilds><Child/><Child/></TransientChilds>, >> actual >> <TransientChild/><TransientChild/>
The mail also reports different spelling. > I suppose the XML was a bit simplified after the doc was written. > >> 3. Checkstyle now shows a number (27) of "disallowed import" warnings. >> Those are imports from "o.a.catalina.tribes" and "o.a.catalina.ha". >> >> I think it just means that this component depends on those, >> and Checkstyle rules needs adjustment here. > > Storeconfig needs that dependency (obvious), so the warning should be > silenced or ignored. > > Rémy > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
