On 05/02/2013 16:09, Rainer Jung wrote:
> I went through the Java classes in tcnative branch 1.1.x. Remember there
> are no such classes in tcnative trunk.
> 
> - in tcnative branches/1.1.x there were no additions,
>   that were missing from TC trunk (good)
> 
> - I first merged all missing additions from
>   the jni classes in TC 7
> 
> - I then also merged all missing additions from
>   the jni classes in TC trunk
> 
> As a result tcnative Java classes are now identical to TC trunk jni
> classes except:
> 
> - additional tcnative classes o.a.t.jni.Buffer and o.a.t.jni.Thread
> - top level classes o.a.t.Apr and apr.properties.
> 
> I would like to replace the folder
> native/branches/1.1.x/java/org/apache/tomcat/jni with an svn external to
> trunk/java/org/apache/tomcat/jni. For this we need to decide on the
> future of the Buffer and Thread class.

Make sure it is an external that specifies a version. That will enable
tags to work properly (and the release process will involve updating the
reference to the latest trunk version).

> a) Either we move them into TC trunk jni
>    (where Mark will likely remove them as unused code?)

I didn't use the unused code detector on that package as there are lots
that Tomcat doesn't use. I'm happy for those classes to be added to
trunk jni.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to