https://issues.apache.org/bugzilla/show_bug.cgi?id=51497
Ognjen Blagojevic <ognjen.d.blagoje...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27312|0 |1
is obsolete| |
--- Comment #8 from Ognjen Blagojevic <ognjen.d.blagoje...@gmail.com> ---
Created attachment 29921
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29921&action=edit
AccessLogValve patch
(In reply to comment #3)
> It would be better to use "assertEquals(expected, result)"
Fixed.
(In reply to comment #4)
> The private method mayBeIPv6Address counts colons,
> but fails to check the value.
Fixed.
(In reply to comment #5)
> Which means that abcdef:80 is treated as an IPv6 address,
> and results in a call to DNS to resolve the host name.
Fixed, it is not treated as IPv6 address anymore. I changed method
mayBeIPv6Address visibility to "protected", and added JUnit test cases.
(In reply to comment #6)
> Also mayBeIPv6Address does not recognise IPv6 scoped addresses
> (%scope) or IPv4 mapped addresses (e.g. ::FFFF:d.d.d.d).
Fixed. Both mayBeIPv6Address and canonize(String) support zone ID (%1,
%eth0...), and IPv4-in-IPv6 (::FFFF:d.d.d.d, ::d.d.d.d, etc).
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
