2013/1/31 sebb <seb...@gmail.com>: > On 31 January 2013 09:58, <ol...@apache.org> wrote: >> Author: olamy >> Date: Thu Jan 31 09:58:49 2013 >> New Revision: 1440892 >> >> URL: http://svn.apache.org/viewvc?rev=1440892&view=rev >> Log: >> fix possible values for clientAuth >> >> Modified: >> >> tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java >> >> tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7RunnerCli.java >> >> Modified: >> tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java >> URL: >> http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java?rev=1440892&r1=1440891&r2=1440892&view=diff >> ============================================================================== >> --- >> tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java >> (original) >> +++ >> tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java >> Thu Jan 31 09:58:49 2013 >> @@ -90,7 +90,7 @@ public class Tomcat7Runner >> >> public boolean debug = false; >> >> - public boolean clientAuth = false; >> + public String clientAuth = "false"; >> >> public String keyAlias = null; > > Do these mutable values really need to be public? > Could they be private or package protected? Maybe but here it's something used by the plugin and there is no purpose to make a kind of public api... The purpose is described here: http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/executable-war-jar.html > > Exposing mutable fields makes it harder to test properly, as changes > may occur at any time. > Also changes to mutable fields are not thread-safe without synchronisation. The class is not marked as thread safe. It's just a class which contains tomcat configuration to start only ONE embeded tomcat.
> >> >> Modified: >> tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7RunnerCli.java >> URL: >> http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7RunnerCli.java?rev=1440892&r1=1440891&r2=1440892&view=diff >> ============================================================================== >> --- >> tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7RunnerCli.java >> (original) >> +++ >> tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7RunnerCli.java >> Thu Jan 31 09:58:49 2013 >> @@ -178,7 +178,7 @@ public class Tomcat7RunnerCli >> } >> if ( line.hasOption( clientAuth.getOpt() ) ) >> { >> - tomcat7Runner.clientAuth = true; >> + tomcat7Runner.clientAuth = clientAuth.getOpt(); >> } >> if ( line.hasOption( keyAlias.getOpt() ) ) >> { >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > -- Olivier Lamy Talend: http://coders.talend.com http://twitter.com/olamy | http://linkedin.com/in/olamy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
