I will fix that. Thanks for review ! 2013/1/30 Konstantin Kolinko <knst.koli...@gmail.com>: > 2013/1/30 <ol...@apache.org>: >> Author: olamy >> Date: Wed Jan 30 10:41:12 2013 >> New Revision: 1440338 >> >> URL: http://svn.apache.org/viewvc?rev=1440338&view=rev >> Log: >> [MTOMCAT-190] Client Certificate settings for connector >> >> Modified: >> >> tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java >> >> Modified: >> tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java >> URL: >> http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java?rev=1440338&r1=1440337&r2=1440338&view=diff >> ============================================================================== >> --- >> tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java >> (original) >> +++ >> tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java >> Wed Jan 30 10:41:12 2013 >> >> + /** >> + * enable client authentication for https (if configured) >> + */ >> + @Parameter( property = "maven.tomcat.https.clientAuth", defaultValue = >> "false" ) >> + protected boolean clientAuth = false; >> + > > 1. Why is it boolean? Tomcat 7 setting is a String with possible > values of "true", "false" and "want". > > http://tomcat.apache.org/tomcat-7.0-doc/config/http.html#SSL_Support_-_BIO_and_NIO > > 2. If you are going to provide similar support for an APR connector, > the setting name appears to be "SSLVerifyClient" with its own set of > possible values. > > Best regards, > Konstantin Kolinko > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
