https://issues.apache.org/bugzilla/show_bug.cgi?id=54503
--- Comment #1 from Christopher Schultz <ch...@christopherschultz.net> --- I'm floored: a great idea, backed-up with a complete set of diffs including test cases and examples. I'm looking forward to diving-into the code further when I get some time. I did have two initial reactions when doing a (very) brief overview of the patch: 1. Is the term "Cloudseal" a requirement? I see that, for instance, the type of authentication is registered as CLOUDSEAL instead of, say, SAML2. I think we'd prefer to use the generic name (SAML2) rather than a particular service (Cloudseal). 2. I noticed that you changed CombinedRealm.getPrincipal(). Can you explain why that needed to change? I don't see any of your code that calls Realm.getPrincipal. Again, thanks for the great contribution. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
