Author: markt
Date: Wed Jan 23 15:57:20 2013
New Revision: 1437507

URL: http://svn.apache.org/viewvc?rev=1437507&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54458
Include exception in error log message
Patch provided by Violeta Georgieva

Modified:
    tomcat/tc7.0.x/trunk/   (props changed)
    tomcat/tc7.0.x/trunk/java/org/apache/catalina/realm/DataSourceRealm.java
    tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
------------------------------------------------------------------------------
  Merged /tomcat/trunk:r1437505

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/realm/DataSourceRealm.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/realm/DataSourceRealm.java?rev=1437507&r1=1437506&r2=1437507&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/realm/DataSourceRealm.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/realm/DataSourceRealm.java 
Wed Jan 23 15:57:20 2013
@@ -455,7 +455,7 @@ public class DataSourceRealm
         } catch(SQLException e) {
             containerLog.error(
                     sm.getString("dataSourceRealm.getPassword.exception",
-                                 username));
+                                 username), e);
         } finally {
             try {
                 if (rs != null) {
@@ -467,7 +467,7 @@ public class DataSourceRealm
             } catch (SQLException e) {
                     containerLog.error(
                         sm.getString("dataSourceRealm.getPassword.exception",
-                             username));
+                             username), e);
                 
             }
         }
@@ -548,7 +548,7 @@ public class DataSourceRealm
             return list;
         } catch(SQLException e) {
             containerLog.error(
-                sm.getString("dataSourceRealm.getRoles.exception", username));
+                sm.getString("dataSourceRealm.getRoles.exception", username), 
e);
         }
         finally {
             try {
@@ -561,7 +561,7 @@ public class DataSourceRealm
             } catch (SQLException e) {
                     containerLog.error(
                         sm.getString("dataSourceRealm.getRoles.exception",
-                                     username));
+                                     username), e);
             }
         }
         

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1437507&r1=1437506&r2=1437507&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Wed Jan 23 15:57:20 2013
@@ -71,6 +71,10 @@
         <code>injection-target</code>. Patch provided by  Violeta Georgieva.
         (markt)
       </fix>
+      <fix>
+        <bug>54458</bug>: Include exception when logging errors in the
+        DataSourceRealm. Patch provided by  Violeta Georgieva. (markt)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Coyote">



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to