Mark, On 1/15/13 4:11 AM, Mark Thomas wrote: > On 15/01/2013 00:53, Christopher Schultz wrote: >> Tim, >> >> Repeating my comment on your BZ comment: >> >> On 1/13/13 5:08 PM, t...@apache.org wrote: >>> Modified: >>> tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/SSLUtil.java >>> >>> > URL: > http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/SSLUtil.java?rev=1432753&r1=1432752&r2=1432753&view=diff > > <snip/> > >> Since you have added methods to this interface, I'm afraid I might >> have to by -1 to this commit (specifically to the 7.0.x branch) >> because it means that Tomcat 7 is no longer binary-compatible and >> dependent code won't compile without modification (which is >> obviously frustrating). > > We've added methods to interfaces that are far more likely to be > extended than the SSL implementation. I have no problems with this change.
If you're okay with it, I'm okay with it. It's obviously an easy fix for anyone with their own implementation of SSLUtil (which would honestly be fairly surprising). I just wasn't sure if Tomcat had an API stability policy or anything like that, especially given the relative maturity of Tomcat 7. -chris
signature.asc
Description: OpenPGP digital signature
