Tim, On 1/13/13 5:13 PM, Tim Whittington wrote: > On Mon, Jan 14, 2013 at 11:10 AM, <bugzi...@apache.org> wrote: >> https://issues.apache.org/bugzilla/show_bug.cgi?id=54406 >> >> --- Comment #2 from Tim Whittington <t...@apache.org> --- >> Fixed in trunk and in 7.0.x and will be included in 7.0.36 onwards. >> >> The change involved a modification to the org.apache.tomcat.util.net.SSLUtil >> interface, which will require updates to custom SSLImplementations. >> >> -- >> You are receiving this mail because: >> You are the assignee for the bug. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > I'm not sure what the convention is for modifying interfaces like > org.apache.tomcat.util.net.SSLUtil/SSLImplementation in a released > branch. > If it's not the done thing to change these in 7.0.x, someone let me > know and I'll change the 7.0.x fix to avoid this.
It might be a big deal. I just in case your commit slipped-through without review, you might want to post a new message to see if there are any objections. Since you have added methods to the interface, I'm afraid I might have to by -1 to this commit (specifically to the 7.0.x branch) because it means that Tomcat 7 is no longer binary-compatible and dependent code won't compile without modification (which is obviously frustrating). What about a different fix for 7.0.x which uses a separate class to handle these two new methods? That would allow the fix with minimal modification but still maintain binary compatibility. -chris
signature.asc
Description: OpenPGP digital signature
