On 11.01.2013 00:40, Mark Thomas wrote:
> The proposed Apache Tomcat 7.0.35 release is now available for voting.
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.35/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-123/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_35/
> 
> The proposed 7.0.35 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.35 Stable

+1 to release.

Details:

- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src completely consistent with svn tag
  Except for executable bits on Tester.java in svn.
  Not critical, already fixed for next release.
- builds fine
  - new warning in
    test/org/apache/catalina/core/TestStandardContextResources.java:
    uses unchecked or unsafe operations
- build result looks consistent with binaries
- no checkstyle complaints
- some Javadoc warnings (only in jdbc-pool, not a regression)
- Unit tests
  - no error or failures
  - some warnings (see below), one new warning type
    concerning NPE in CoyoteAdapter when calling access log
- JMX MBean-Comparison OK
  - OpenFileDescriptorCount down from 61 to 57

Build and tests were done using Java 1.6.0_37. OS was Solaris 10 Sparc,
tcnative was 1.1.24 based on APR 1.4.6 and OpenSSL 1.0.1c (plus two
patches).

Unit test warnings (except for tribes and the access log exceptions all
of those look like 7.0.33 and
before):

- Exception while attempting to add an entry to the access log
  in org.apache.catalina.connector.CoyoteAdapter log
  while running org.apache.el.TestELInJsp and
  org.apache.jasper.compiler.TestParser.

The exception stack in both cases was:

java.lang.NullPointerException
at org.apache.catalina.connector.CoyoteAdapter.log(CoyoteAdapter.java:511)
at
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1033)
at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1680)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)

Line 511 in CoyoteAdapter is
connector.getService().getContainer().logAccess(...);

- org.apache.catalina.deploy.TestWebXmlOrdering
  - BIO, NIO and APR: [main]
org.apache.catalina.deploy.WebXml.orderWebFragments Used a wrong
fragment name z at web.xml absolute-ordering tag!

- org.apache.tomcat.util.net.TestCustomSsl
  - BIO twice "Exception getting SSL attributes"
    in org.apache.coyote.http11.Http11Processor actionInternal
    exception is:
    javax.net.ssl.SSLProtocolException: handshake alert: no_certificate
  - NIO twice "WARNING: Exception re-negotiating SSL connection"
    in org.apache.coyote.http11.Http11NioProcessor actionInternal

- tribes: several warnings, roughly same as before

Unit test SEVERE messages: 225 total (+7), about 35 unique messages
Most of those are of type "Servlet.service() for servlet ... threw
exception" (134 times). 3 less not stopped threads errors, some deltas
in tribes errors, 3 times each of the new messages

WebXml.mergeLifecycleCallback The [Post Construct Methods] with name [a]
was defined inconsistently in multiple fragments including fragment with
name [null] located at [null]

and

WebXml.mergeLifecycleCallback The [Pre Destroy Methods] with name [b]
was defined inconsistently in multiple fragments including fragment with
name [null] located at [null]

and twice the new

Error processing request

with reason an NPE:

java.lang.NullPointerException
        at
org.apache.tomcat.util.net.NioBlockingSelector.write(NioBlockingSelector.java:129)
        at
org.apache.tomcat.util.net.NioSelectorPool.write(NioSelectorPool.java:174)
        at
org.apache.coyote.http11.InternalNioOutputBuffer.writeToSocket(InternalNioOutputBuffer.java:163)
        at
org.apache.coyote.http11.InternalNioOutputBuffer.flushBuffer(InternalNioOutputBuffer.java:242)
        at
org.apache.coyote.http11.InternalNioOutputBuffer.endRequest(InternalNioOutputBuffer.java:121)
        at
org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:749)
        at org.apache.coyote.Response.action(Response.java:173)
        at org.apache.coyote.Response.finish(Response.java:279)
        at
org.apache.catalina.connector.OutputBuffer.close(OutputBuffer.java:293)
        at
org.apache.catalina.connector.Response.finishResponse(Response.java:513)
        at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:434)
        at
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004)
        at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
        at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1680)
        at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
        at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
        at java.lang.Thread.run(Thread.java:662)


"Exception" in output of unit tests: 220 times (+11), of these 75 times
"javax.servlet.ServletException: Opps."

I'm not claiming that any of the SEVERE or Exception messages are
important. Total numbers of warnings, SEVERE and exceptions are
slightly larger than for previous releases.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to