Christopher Schultz <ch...@christopherschultz.net> wrote:
>Mark,
>> // -------------------- Hash code --------------------
>>
>> + @Override
>> + public int hashCode() {
>> + if (hasHashCode) {
>> + return hashCode;
>> + }
>> + int code = 0;
>> +
>> + code = hash();
>> + hashCode = code;
>> + hasHashCode = true;
>> + return code;
>> + }
>
>Any particular reason for the dead store of 0 to 'code' local?
>
>In fact, there seems to be much more code in there than necessary. Why
>not:
The code was copied directly from MessageBytes (as per the original commit
log). My primary concern for this commit was consistency rather than improving
the code. Any changes need to be made to all three classes.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
