On 06.12.2012 12:26, Mark Thomas wrote:
> The proposed Apache Tomcat 7.0.34 release is now available for voting.
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.34/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-113/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_34/
> 
> The proposed 7.0.34 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.34 Stable

+1 to release.

This time a quick reply, because I already tested after tagging and
uploading was done. I saw no other tags so I assume no changes were
applied after the original uploading.

Most notable observation:

Details:

- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src completely consistent with svn tag
- builds fine
  - deprecation warning in jdbc-pool (SlowQueryReport) is gone
- build result looks consistent with binaries
- no checkstyle complaints
- some Javadoc warnings (only in jdbc-pool, not a regression)
- Unit tests
  - no error or failures
  - some warnings (see below)
  - one new observation: I use test.formatter to switch to the
    OneLineFormatter. The STDOUT lines from junit are typically
    still in the JUL 2 line format. With 7.0.34 the STDOUT output
    of TestNonLoginAndBasicAuthenticator switch to OneLine.
    If we could get the same effect for all tests it would be great,
    but I didn't see any obvious reason why that happened.
- JMX MBean-Comparison OK
  - only one expected new attribute "renameOnRotate" for ALV

Build and tests were done using Java 1.6.0_37. OS was Solaris 10 Sparc,
tcnative was 1.1.24 based on APR 1.4.6 and OpenSSL 1.0.1c (plus two
patches).

Unit test warnings (except for tribes all of those look like 7.0.33 and
before):

- org.apache.catalina.deploy.TestWebXmlOrdering
  - BIO, NIO and APR: [main]
org.apache.catalina.deploy.WebXml.orderWebFragments Used a wrong
fragment name z at web.xml absolute-ordering tag!

- org.apache.tomcat.util.net.TestCustomSsl
  - BIO twice "Exception getting SSL attributes"
    in org.apache.coyote.http11.Http11Processor actionInternal
    exception is:
    javax.net.ssl.SSLProtocolException: handshake alert: no_certificate
  - NIO twice "WARNING: Exception re-negotiating SSL connection"
    in org.apache.coyote.http11.Http11NioProcessor actionInternal

- tribes: several warnings

Unit test SEVERE messages: 218 total, about 35 unique messages
Most of those are of type "Servlet.service() for servlet ... threw
exception".

"Exception" in output of unit tests: 209 times, of these 75 times
"javax.servlet.ServletException: Opps."

I'm not claiming that any of the SEVERE or Exception messages are new
ones or important. Total numbers of warnings, SEVERE and exceptions are
a bit smaller than for previous releases.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to