On 03.12.2012 13:45, Konstantin Kolinko wrote: > 2012/12/3 Rainer Jung <rainer.j...@kippdata.de>: >> On 03.12.2012 12:09, Konstantin Kolinko wrote: >>> 2012/11/29 <rj...@apache.org>:
> On second thought, > a) It is pointless to change server.xml if we are not also adding > renameOnRotate="true" there. It is of little value. Agreed. > b) I wonder whether there will be some problems on Windows when using > this feature. (A file deletion does not happen immediately there. I > wonder what is the case with renames). I haven't yet tried it, but the usual experience is that evenb if a file is open so you can't delete it, you can still change its name. So I expect it to work ... > So I would keep the current default of renameOnRotate="false". Me as well :) > Maybe just add a configuration example to valves.html. I did some reworking of the ALV docs, especially adding a general paragraph about the file name. I hope this and move of the trailing dot from the prefix default to a leading dot in the fileDateFormat default should make it clear. >>> a) It should be easy to extend this to skip rotation if file.length() is 0. >> >> Not so sure about that one. An empty rotated file shows there was >> nothing written. Skipping rotation might lead to the question, whether >> rotation is broken (or the server was down during the change of date). >> >> So I'd prefer keeping the rotation since it isn't so expensive and >> doesn't happen to early. >> > > Just a different feature that people ask sometime: do not create a log > file if it is empty. > > An RFE for JULI: > https://issues.apache.org/bugzilla/show_bug.cgi?id=53620 > > An example is those "host-manager." logs that are in the default > configuration, but nearly nobody is using that app. Got it. I might come back to that one ... Regards, Rainer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
