Brian Burch <br...@pingtoo.com> wrote:
>On 29/11/12 14:37, bugzi...@apache.org wrote: >> https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 >> >> Mark Thomas <ma...@apache.org> changed: >> >> What |Removed |Added >> >---------------------------------------------------------------------------- >> Status|NEW |RESOLVED >> Resolution|--- |FIXED >> >> --- Comment #6 from Mark Thomas <ma...@apache.org> --- >> Thanks. Patch applied to trunk and 7.0.x and will be included in >7.0.34 >> onwards. >> >> Applying the patch generated a bunch of IDE warnings (we try to keep >the code >> clean of those) which were fixed by r1415178 and r1415179. > >Thanks Mark. > >I use netbeans, not eclipse. My change was clear of ide warnings and it > >also passed checkstyle. > >When I looked quickly at your change, the "-" and "+" lines appeared to > >be identical to me, so I was puzzled. > >Could you give me an example of what kind of warnings you were getting They were all auto[un]boxing warnings. The fix was Boolean -> boolean. The other change was removing the unused user and pwd parameters from the doTestBasic method. We have a fairly strict set of warnings enabled although they aren't actually that far from the Eclipse defaults. In many cases fixing the warnings is purely cosmetic although they do catch the occasional subtle bug. One of the improvements for Tomcat 8 is getting the code base down to zero warnings. We are about 30 FindBugs warnings away from that - although there are some commented out Checkstyle settings I'd like to enabel that will add a few thousand ;) Removing unused code is another area for improvement and there is some way to go on that. Thanks again for your work on the authenticators, Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
