On 13/11/2012 13:47, Mark Thomas wrote:
> On 13/11/2012 01:08, Konstantin Kolinko wrote:
>> 2012/11/12  <ma...@apache.org>:
>>> Author: markt
>>> Date: Sun Nov 11 23:32:43 2012
>>> New Revision: 1408150
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1408150&view=rev
>>> Log:
>>> both timeout and complete, as with all container callbacks must be invoked 
>>> with the right context
>>> Backport of fhanik's r1356898
>>
>>
>> 1. The change only takes care of timeout().
>> What about complete (fireOnComplete()) that is mentioned in the commit
>> message and in the changelog?
> 
> This was a straight backport so my subsequent change would apply
> cleanly. I agree it looks like firOnComplete() needs this too.
> 
>>
>> 2. I wonder what about running with SecurityManager. (Well, timeout()
>> is probably called by Tomcat code, so there might be no concern, or
>> maybe you will notice it while running TCK).
> 
> It looks to me like neither can be called directly from user code.
I was wrong on this. fireOnComplete() can get triggered directly by user
code. I have just fixed this.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to