Excellent, thanks for the quick addition. Sorry about the improper formatting, modified it in a basic editor and didnt run a formatter on it. Noted for the future.
On Fri, Nov 9, 2012 at 2:36 PM, Mark Thomas <ma...@apache.org> wrote: > On 09/11/2012 17:14, Mark Thomas wrote: > > On 09/11/2012 16:03, Sean Winterberger wrote: > >> We are attempting to implement ping/pong functionality but have run > into a > >> wall with the Tomcat Websocket implementation. Unless we are missing > >> something, there seems to be no way of modifying the opcode on a frame > >> prior to sending it without using reflection. The WsOutbound object > >> currently has a method for pong, but we would like to be sending a ping > >> from the server to all clients. > >> > >> We could implement our own ping/pong with our client devices however the > >> RFC implementation is much more attractive due to its small size, plus > we > >> already have it implemented in our websocket implementation on the > client > >> side. > >> > >> If there was a way to safely get a handle on the UpgradeOutbound object > we > >> could write the frame ourselves. > >> > >> Is there any plan to add a ping(ByteBuffer data) method or a method > which > >> allows modifications to the opcode of a frame? > > > > No plans (focus is currently on Tomcat 7 bugs and Tomcat 8) but a patch > > that implemented ping should be pretty simple and is very likely to be > > accepted. ping() is almost just a copy and paste of pong(). > > > > An enhancement request in BZ is the way to go with this. If you are able > > to provide a patch in the next few days it will almost certainly make it > > into 7.0.33 else it should be in 7.0.34. > > https://issues.apache.org/bugzilla/show_bug.cgi?id=54127 > > Patch provided. > Patch applied. > Will be in 7.0.33. > > Thanks Sean. > > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
