On 12/10/2012 13:24, Martin Grigorov wrote: Please use quoting, particularly when you have a few short comments on a very large e-mail. Without quoting, your comments were more effort to find.
>> Added: tomcat/trunk/java/javax/net/websocket/HandshakeRequest.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/javax/net/websocket/HandshakeRequest.java?rev=1397522&view=auto <snip/> >> + Object getSession(); > > ^^ > Shouldn't this return a Session instead ? No. That is an HTTP Session object and Object is used to avoid a dependency on the Servlet spec. I'll add some Javadoc. (I can't just copy the RI's Javadoc because of licensing). >> Added: tomcat/trunk/java/javax/net/websocket/Session.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/javax/net/websocket/Session.java?rev=1397522&view=auto <snip/> >> + RemoteEndpoint<?> getRemote(); >> + >> + RemoteEndpoint<T> getRemoteL(Class<T> c); > > Is there a typo in the method name ? Is the 'L' needed ? That is what the spec currently says. It looks like a typo. I've raised it with the EG. Thanks for the review. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
