On 08/09/2012 11:52, Konstantin Kolinko wrote: > 2012/9/6 <schu...@apache.org>: >> Author: schultz >> Date: Thu Sep 6 15:08:58 2012 >> New Revision: 1381635 >> >> URL: http://svn.apache.org/viewvc?rev=1381635&view=rev >> Log: >> Added multi-op modes to JMXProxyServlet. >> >> >> Modified: >> tomcat/tc7.0.x/trunk/ (props changed) >> >> tomcat/tc7.0.x/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java >> tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml >> tomcat/tc7.0.x/trunk/webapps/docs/manager-howto.xml >> >> Propchange: tomcat/tc7.0.x/trunk/ >> ------------------------------------------------------------------------------ >> Merged /tomcat/trunk:r1381633 >> >> + if(null != request.getParameter("invokeAndGet")) { >> ... > > 1. This broke formatting of the manager-howto page. > You should wrap such long samples. > > 2. Not a showstopper, but personally I dislike such limited solutions,
+1. This has the potential to get very messy, very quickly. I'm not massively concerned about the current state of the code but any further expansion of the list of possible combinations would be much better implemented as Konstantin suggests. Mark > > Maybe instead of introducing 4 specific command combinations, do > something more general. > > - Add new parameter, > operations= comma-separated list of operations, > - Prepend operands by "number" + ".", starting with 0. > > So your > > http://webserver/manager/jmxproxy/?invokeAndSet&invoke=BEANNAME&op=METHODNAME&ps=COMMASEPARATEDPARAMETERS&set=BEANNAME&att=MYATTRIBUTE&val=NEWVALUE > > becomes > http://webserver/manager/jmxproxy/?operations=invoke,set&0.invoke=BEANNAME&0.op=METHODNAME&0.ps=COMMASEPARATEDPARAMETERS&1.set=BEANNAME&1.att=MYATTRIBUTE&1.val=NEWVALUE > > Possible operations: > invoke, set, get, query. > > Best regards, > Konstantin Kolinko > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
