https://issues.apache.org/bugzilla/show_bug.cgi?id=51496

--- Comment #5 from Ralph Plawetzki <ra...@purejava.org> ---
Dear Konstantin,

thank you very much for the fast review.

I'd like to explain why I checked for the Tomcat Monitor application whether it
is configured to autolaunch: in tomcat.nsi $TomcatServiceName is also part of
the registry entry stored for the Tomcat Monitor application and it seemed
better to check that than to use an external NSIS library to read the installed
services as suggested in comment 1.

But you are absolutely right, it's better to check if a service of the same
name is already installed. I looked a little further into MSDN documentation
and found that services are also listed in the registry under HKLM
SYSTEM\CurrentControlSet\Services\ so I changed  the registry check in the
patch.

Please find the new patch attached.
You can check that it works by installing the tomcat service and running the
installer a second time. If a service of the same name exists, it prompts the
user with a pop-up and remains on the configuration page.

The patch is in svn diff format against trunk.

Regards,
Ralph

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to