[ https://issues.apache.org/jira/browse/MTOMCAT-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428856#comment-13428856 ]
Hudson commented on MTOMCAT-124: -------------------------------- Integrated in TomcatMavenPlugin-mvn3.x #192 (See [https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/192/]) [MTOMCAT-124] tomcat-maven-archetype unused generation parameters Submitted by Patrick Garcia. (Revision 1369603) Result = FAILURE olamy : http://svn.apache.org/viewvc/?view=rev&rev=1369603 Files : * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/pom.xml * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/pom.xml * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src/main * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src/main/java * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src/main/java/api * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src/main/java/api/impl * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src/main/java/api/impl/DefaultHelloService.java * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src/main/resources * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src/main/resources/META-INF * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src/main/resources/META-INF/spring-context.xml * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src/test * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src/test/java * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src/test/java/api * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src/test/java/api/impl * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api-impl/src/test/java/api/impl/TestDefaultHelloService.java * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api/pom.xml * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api/src * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api/src/main * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api/src/main/java * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api/src/main/java/api * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-api/src/main/java/api/HelloService.java * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp-exec * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp-exec/pom.xml * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp-it * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp-it/pom.xml * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp-it/src * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp-it/src/test * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp-it/src/test/context.xml * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp-it/src/test/java * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp-it/src/test/java/webapp * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp-it/src/test/java/webapp/test * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp-it/src/test/java/webapp/test/SimpleTest.java * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/pom.xml * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/src * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/src/main * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/src/main/resources * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/src/main/resources/log4j.xml * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/src/main/webapp * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/src/main/webapp/WEB-INF * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/src/main/webapp/WEB-INF/applicationContext.xml * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/src/main/webapp/WEB-INF/web.xml * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/src/main/webapp/css * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/src/main/webapp/css/bootstrap.min.1.4.0.css * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/src/main/webapp/index.html * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/src/main/webapp/js * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/__rootArtifactId__-webapp/src/main/webapp/js/jquery-1.7.js * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/basic-api * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/basic-api-impl * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/basic-webapp * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/basic-webapp-exec * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/basic-webapp-it/src * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/pom.xml * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/test/resources/projects/basic/archetype.properties * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/test/resources/projects/basic/goal.txt * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/test/resources/projects/customized * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/test/resources/projects/customized/archetype.properties * /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/test/resources/projects/customized/goal.txt > tomcat-maven-archetype unused generation parameters > --------------------------------------------------- > > Key: MTOMCAT-124 > URL: https://issues.apache.org/jira/browse/MTOMCAT-124 > Project: Apache Tomcat Maven Plugin > Issue Type: Improvement > Affects Versions: 2.0-beta-1 > Reporter: patrick garcia > Assignee: Olivier Lamy (*$^¨%`£) > Priority: Trivial > Labels: archetype, maven, tomcat > Fix For: 2.0 > > Attachments: MTOMCAT-124-tomcat-maven-archetype.patch, > MTOMCAT-124-tomcat-maven-archetype2.patch > > > I found several problems on the superb and very useful > "tomcat-maven-archetype" > The improvement I propos are the followings: > 1/ > "groupId" and "version" can have default values but should be prompt for user > value the same way as for "version" of > "org.apache.maven.archetypes:maven-archetype-quickstart:1.1" > "org.apache.maven.archetypes:maven-archetype-quickstart:1.1" proposes a > default "version" and prompt the user for modification at the same time. > Pressing enter validate the default value. > 2/ > Following variables are not in used: > artifactId-api > artifactId-api-impl > artifactId-webapp > artifactId-webapp-exec > artifactId-webapp-it > This variables should impact the "mvn archetype:generate" behaviour > 3/ > I propos to change the default values of : > artifactId-api = ${artifactId}-api > artifactId-api-impl = ${artifactId}-api-impl > artifactId-webapp = ${artifactId}-webapp > artifactId-webapp-exec = ${artifactId}-webapp-exec > artifactId-webapp-it = ${artifactId}-webapp-it > 4/ > rootArtifactId cat be renamed as artifactId with no default value > I will propos patches for this later. I, first, have to understand > "archetype" framework. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org