I know the vote is over, test result given here for the sake of completeness.

On 03.07.2012 13:30, Mark Thomas wrote:
The proposed Apache Tomcat 7.0.29 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.29/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-014/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_29/

The proposed 7.0.29 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 7.0.29 Stable

+1 to release

Most noteable observation:

Details:

- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent completely with svn tag
- builds fine
- build result looks consistent with binaries
- no checkstyle complaints
- some Javadoc warnings (only in jdbc-pool, see below)
- Unit tests one failure and some warnings (see below)
- JMX MBean-Comparison
  - new expected attribute "aprRequired"in ProtocolHandler MBeans

Build and tests were done using Java 1.6.0_30, OS was Solaris 10 Sparc,
tcnative was 1.1.24 based on APR 1.4.6 and OpenSSL 1.0.1c (plus two patches).

Javadoc Warnings in jdbc-pool:

[javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:544: warning - Tag @link: can't find getParentLogger in javax.sql.DataSource [javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:1294: warning - @inheritDoc used but purge() does not override or implement any method. [javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:1305: warning - @inheritDoc used but purgeOnReturn() does not override or implement any method. [javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:1294: warning - @inheritDoc used but purge() does not override or implement any method. [javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:1305: warning - @inheritDoc used but purgeOnReturn() does not override or implement any method. [javadoc] .../tomcat/jdbc/pool/JdbcInterceptor.java:67: warning - Tag @link: can't find isValid(boolean) in java.sql.Connection
  [javadoc] Building index for all the packages and classes...
[javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:1294: warning - @inheritDoc used but purge() does not override or implement any method. [javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:1305: warning - @inheritDoc used but purgeOnReturn() does not override or implement any method.


Unit test failure:

One failure in org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak for NIO:

Testcase: testTimerThreadLeak took 4.328 sec
        FAILED
null
junit.framework.AssertionFailedError: null
at org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak.testTimerThreadLeak(TestWebappClassLoaderExecutorMemoryLeak.java:72)

I'd say the one second sleep before testing the timer thread is a bit to short on this slow system:

Jul 10, 2012 5:26:30 AM org.apache.coyote.AbstractProtocol init
INFO: Initializing ProtocolHandler ["http-nio-127.0.0.1-auto-1"]
Jul 10, 2012 5:26:30 AM org.apache.tomcat.util.net.NioSelectorPool getSharedSelector
INFO: Using a shared selector for servlet write/read
Jul 10, 2012 5:26:30 AM org.apache.catalina.core.StandardService startInternal
INFO: Starting service Tomcat
Jul 10, 2012 5:26:30 AM org.apache.catalina.core.StandardEngine startInternal
INFO: Starting Servlet Engine: Apache Tomcat/7.0.29
Jul 10, 2012 5:26:31 AM org.apache.catalina.util.SessionIdGenerator createSecureRandom INFO: Creation of SecureRandom instance for session ID generation using [INSECURE] took [359] milliseconds.
Jul 10, 2012 5:26:31 AM org.apache.coyote.AbstractProtocol start
INFO: Starting ProtocolHandler ["http-nio-127.0.0.1-auto-1-41357"]
Jul 10, 2012 5:26:31 AM org.apache.catalina.loader.WebappClassLoader clearReferencesThreads SEVERE: The web application [] appears to have started a thread named [pool-1-thread-1] but has failed to stop it. This is very likely to create a memory leak. Jul 10, 2012 5:26:31 AM org.apache.catalina.loader.WebappClassLoader clearReferencesThreads SEVERE: The web application [] appears to have started a thread named [pool-1-thread-2] but has failed to stop it. This is very likely to create a memory leak. Jul 10, 2012 5:26:31 AM org.apache.catalina.loader.WebappClassLoader clearReferencesThreads SEVERE: The web application [] appears to have started a thread named [pool-1-thread-3] but has failed to stop it. This is very likely to create a memory leak. Jul 10, 2012 5:26:31 AM org.apache.catalina.loader.WebappClassLoader clearReferencesThreads SEVERE: The web application [] appears to have started a thread named [pool-1-thread-4] but has failed to stop it. This is very likely to create a memory leak. Jul 10, 2012 5:26:31 AM org.apache.catalina.loader.WebappClassLoader clearReferencesThreads SEVERE: The web application [] appears to have started a thread named [pool-1-thread-5] but has failed to stop it. This is very likely to create a memory leak.
Jul 10, 2012 5:26:32 AM org.apache.coyote.AbstractProtocol pause
INFO: Pausing ProtocolHandler ["http-nio-127.0.0.1-auto-1-41357"]
Jul 10, 2012 5:26:32 AM org.apache.catalina.core.StandardService stopInternal
INFO: Stopping service Tomcat
Jul 10, 2012 5:26:32 AM org.apache.coyote.AbstractProtocol stop
INFO: Stopping ProtocolHandler ["http-nio-127.0.0.1-auto-1-41357"]
Jul 10, 2012 5:26:32 AM org.apache.coyote.AbstractProtocol destroy
INFO: Destroying ProtocolHandler ["http-nio-127.0.0.1-auto-1-41357"]


Unit test warnings (looks like 7.0.28):

- org.apache.catalina.deploy.TestWebXmlOrdering
- BIO, NIO and APR: [main] org.apache.catalina.deploy.WebXml.orderWebFragments Used a wrong fragment name z at web.xml absolute-ordering tag!

- org.apache.tomcat.util.net.TestCustomSsl
  - BIO twice "Exception getting SSL attributes"
  - NIO twice "WARNING: Exception re-negotiating SSL connection"

- tribes

Many, looks about the same as listed in the 7.0.28 vote thread.

Unit test SEVERE messages: 208 total, 78 unique messages

"Exception" in output of ant test: 199 times, of these 75 times "javax.servlet.ServletException: Opps."

I'm not claiming that any of the SEVERE or Exception messages are new ones.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to