Author: kkolinko Date: Sun Jul 1 20:31:00 2012 New Revision: 1356007 URL: http://svn.apache.org/viewvc?rev=1356007&view=rev Log: Review of r1355615 Correct obvious typos Remove trailing whitespace as reminded by checkstyle
Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java tomcat/trunk/webapps/docs/config/realm.xml Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java?rev=1356007&r1=1356006&r2=1356007&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java (original) +++ tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java Sun Jul 1 20:31:00 2012 @@ -1464,7 +1464,7 @@ public class JNDIRealm extends RealmBase if (userRoleName != null) roles = addAttributeValues(userRoleName, attrs, roles); - return new User(username, dn, password, roles, password); + return new User(username, dn, password, roles, userRoleAttrValue); } Modified: tomcat/trunk/webapps/docs/config/realm.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/realm.xml?rev=1356007&r1=1356006&r2=1356007&view=diff ============================================================================== --- tomcat/trunk/webapps/docs/config/realm.xml (original) +++ tomcat/trunk/webapps/docs/config/realm.xml Sun Jul 1 20:31:00 2012 @@ -475,9 +475,9 @@ <p>The LDAP filter expression used for performing role searches. Use <code>{0}</code> to substitute the distinguished name (DN) of the user, and/or <code>{1}</code> to - substitute the username, and/or <code>{2}</code> the value of the - userRoleAttribute attribute from the users directory entry. - If not specified a role search does + substitute the username, and/or <code>{2}</code> the value of the + userRoleAttribute attribute from the user's directory entry. + If not specified a role search does not take place and roles are taken only from the attribute in the user's entry specified by the <code>userRoleName</code> property.</p> @@ -572,12 +572,12 @@ not specified all the roles for a user derive from the role search.</p> </attribute> - + <attribute name="userRoleAttribute" required="false"> <p>The name of an attribute in the user's directory entry - containing the value that you wish to use when you search for - roles. This is especially useful for RFC 2307 where - the role memberUid can be the <code>uid</code> or the + containing the value that you wish to use when you search for + roles. This is especially useful for RFC 2307 where + the role memberUid can be the <code>uid</code> or the <code>uidNumber</code> of the user. This value will be marked as <code>{2}</code> in your role pattern. This value will NOT be available for nested group searches, --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org