On 11.06.2012 14:54, Mladen Turk wrote:
Version 1.1.24 is feature-add release containing additional
API to set per-socket timeouts inside Poller.
The proposed release artefacts can be found at [1],
and the build was done using tag [2].
The VOTE will remain open for at least 48 hours.
The Apache Tomcat Native 1.1.24 is
[X] Stable, go ahead and release
[ ] Broken because of ...
+1 to release
Detailed results ("-" indicates things which we could improve). Though
the list is long, it is slightly shorter than when I checked last time
(1.1.22). Overall I'm still +1 for stable, because I didn't find
regressions. But there is room for improvement.
+ Tested with Java 1.6.0_30 (but configured against Java 1.5),
APR 1.4.6 and OpenSSL 1.0.1c
+ Platforms Solaris 8+10 Sparc, SLES 10, 32 and 64 Bits,
SLES 11 64 Bits, RHEL 5+6 64 Bits
+ MD5 OK
+ signatures OK
+ key in KEYS file
- KEYS file is contained in the source distribution,
I think it would be better to remove it there, because
people should *not* check the key against one in the untrusted
download. The file differs from the one in the download area
(it is just a subset)
- name of ocsp binary changed from
...win32-ocsp... to ...ocsp-win32...
+ gz and zip for sources consistent
- Except for different permissions: zip seems to also contain group
write permissions. Not a real problem, but it's a bit strange
that perms differ between the archive.
+ source dist consistent with svn tag
- Except for the following pieces missing in the source dist:
- jnirelease.sh
- xdocs (but sources contain docs generated from xdocs)
I suggets for the future we also include the script and the xdocs
to make source dist more complete and self-contained.
- README.txt:
- paths beginning with examples/ miss a leading "jni/"
- ant comands are wrong ("run-echo" instead of "echo-example"
and probably "run-ssl-server" or "run-local-server" instead
of "server-example".
- config-guess and config.sub could get an update this year
('2011-05-11' resp. '2011-03-23' instead of recent '2012-06-10'
resp. '2012-04-18').
+ recreated release with jnirelease script, results are
consistent with source dist, except for minor expected diffs in
CHANGELOG.txt, build-outputs.mk and generated docs
(whitespace and attribute ordering)
- Warnings during "make" on Solaris:
src/file.c: In function 'Java_org_apache_tomcat_jni_File_writev':
src/file.c:384: warning: pointer targets in assignment differ in signedness
src/file.c:390: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness
src/file.c: In function 'Java_org_apache_tomcat_jni_File_writevFull':
src/file.c:418: warning: pointer targets in assignment differ in signedness
src/file.c:428: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness
src/network.c: In function 'Java_org_apache_tomcat_jni_Socket_sendv':
src/network.c:668: warning: pointer targets in assignment differ in
signedness
src/network.c:674: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness
src/network.c: In function 'Java_org_apache_tomcat_jni_Socket_sendfile':
src/network.c:1220: warning: pointer targets in assignment differ in
signedness
src/network.c:1225: warning: pointer targets in assignment differ in
signedness
src/network.c:1243: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness
src/network.c:1247: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness
src/poll.c:271: warning: 'remove_all' defined but not used
src/ssl.c: In function 'ssl_rand_make':
src/ssl.c:469: warning: value computed is not used
+ make succeeds and builds lib
+ all unit tests contained in TC trunk run successful with
APR connector and this version of tcative
Concerning the Java classes in the source distribution:
- it is unclear to me, why they are still distributed.
Aren't the official sources in trunk/java/org/apache/tomcat/jni?
Note that they are not identical and the tcnative version of the
classes is outdated and not maintained any more. So IMHO we should
no longer distribute them. Either remove from the distribution,
or distribute the TC 7 or trunk ones.
If we remove them, what about the test and examples classes?
I think they have no other home.
Furthermore some of the old files do not exist inside TC:
- Apr.java, apr.properties, jni/Buffer.java and jni/Thread.java
- ant part of build:
- No mentioning of running "ant download" before tests. Without
it test compilation fails.
- "ant test" fails in line 85 of SocketServerTestSuite.java, because
on my system the checking for precisely 2 milliseconds won't work.
The call returns after 11 millis not after 2
- "ant run-echo": will fail, because by default uses privileged
port 23. Maybe switch to 8023? Users should not run tests as root.
- "ant run-ssl-server": Could't we include a test certificates in the
test folder? What should the test produce, if run successfully?
- "ant run-local-server": Creates a unix socket "\\.\PIPE\test" in the
examples directory, then waits. How is the test expected to work?
And the file name doesn't seem to be appropriate for Unix.
- run-echo, run-ssl-server and run-local-server: I couldn't figure
out, what those were actually supposed to show (what is a positive
result vs. a negative one).
Concerning the famous SSL renegotiation problem:
It is unclear to me, what the current state is. It looks like we support
the unsafe legacy reneg whenever the OpenSSL used during build time
supports it. There is no configuration option to switch it off during
runtime. Right?
Is it correct, that client initiated reneg is not supported and thus the
known attacks will not work even with old OpenSSL?
Should we add a remark about this topic to the docs?
Finally there is no impl for Linux to retrieve
* inf[7] - Idle Time in microseconds
* inf[8] - Kernel Time in microseconds
* inf[9] - User Time in microseconds
* inf[10] - Process creation time (apr_time_t)
* inf[11] - Process Kernel Time in microseconds
* inf[12] - Process User Time in microseconds
I implemented those for Solaris long ago and thought they existed for
Linux from the beginning. But in fact for Linux there are only memory
figures implemented.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
