Author: kkolinko
Date: Sat Jun 9 13:11:57 2012
New Revision: 1348398
URL: http://svn.apache.org/viewvc?rev=1348398&view=rev
Log:
Review of r1345026, comparing it with proposed patch for BZ 52955:
Add final modifiers to improve thread safety
Modified:
tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java?rev=1348398&r1=1348397&r2=1348398&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java Sat Jun 9
13:11:57 2012
@@ -1601,9 +1601,9 @@ public abstract class ContainerBase exte
}
private static class StartStopThreadFactory implements ThreadFactory {
- private ThreadGroup group;
- private AtomicInteger threadNumber = new AtomicInteger(1);
- private String namePrefix;
+ private final ThreadGroup group;
+ private final AtomicInteger threadNumber = new AtomicInteger(1);
+ private final String namePrefix;
public StartStopThreadFactory(String namePrefix) {
SecurityManager s = System.getSecurityManager();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]