Author: markt Date: Sun May 6 21:27:55 2012 New Revision: 1334787 URL: http://svn.apache.org/viewvc?rev=1334787&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52055 Ensure input filters are recycled when the request is recycled for all connectors.
Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java?rev=1334787&r1=1334786&r2=1334787&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java Sun May 6 21:27:55 2012 @@ -248,6 +248,11 @@ public abstract class AbstractInputBuffe // Recycle Request object request.recycle(); + // Recycle filters + for (int i = 0; i <= lastActiveFilter; i++) { + activeFilters[i].recycle(); + } + lastValid = 0; pos = 0; lastActiveFilter = -1; Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java?rev=1334787&r1=1334786&r2=1334787&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java Sun May 6 21:27:55 2012 @@ -175,11 +175,6 @@ public class InternalNioInputBuffer exte */ @Override public void recycle() { - // Recycle filters - for (int i = 0; i <= lastActiveFilter; i++) { - activeFilters[i].recycle(); - } - // This must be after filters since it resets the lastFilterIndex super.recycle(); socket = null; headerParsePos = HeaderParsePosition.HEADER_START; --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org