https://issues.apache.org/bugzilla/show_bug.cgi?id=52688
--- Comment #6 from Mark <markclaass...@gmail.com> 2012-03-28 18:01:27 UTC --- What I really want to be able to do is delete older access log files. I was thinking that using a standard logger in the AccessLogValve was the way to do that. However, this idea received some resistance because of the potential performance problem. (Note: In tests that I could mock up here, the change was not really noticeable... the average time was slightly less than 1 millis using the current mechanism and slightly more than 1 millis using a standard logger. I did not have a good way to test what would happen under a heavy load...which is the only case in which the performance would really matter.) However, there are some other things that the AccessLogValve does that I could not account for. For instance, the ExtendedAccessLogValve puts a header at the top of every file; something it can do since it controls the creation of the files. The header contains the format for the entries, presumably for automated parsing. Since I did not have easy access to good testing facilities, and I thought that deleting old files would be a generally useful feature, I did a smaller patch that targets the problem a bit better. I felt this would encounter less resistance and would hopefully be adopted sooner and with less risk. The original attachments are no longer in my purposed solution. The new solution simply adds the capability to delete old files to the existing logging mechanism. The feature is off by default so that the behavior will be backwards compatible. One error message was added to .properties file, although I did not translate it to the other supported languages. I believe I added the parameters appropriately to the mbeans descriptor file. Once thing thing that I was a bit unsure about was that the files are sorted by their last modified times to determine which files are to be deleted. This seemed like a good way to do it, although other ways exist (like parsing the date extension of each file and sorting by Dates). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
