On 26.03.2012 12:49, Mladen Turk wrote:
On 03/25/2012 11:00 PM, Le Huy wrote:
Hi
I am facing problem in using jkstatus to update subworker lb_factor,
it seems that after changing it, the mod_jk balancer does not change
anything
Looking at source code in trunk, I think that there is bug , I
include herewith the 2 changes that I think will fix the problem,
It won't fix the problems.
It'll cause IIS to crash on recycle.
Think that the entire jkstatus needs to get reviewed
cause the current code is unnecessary complex.
for (i = 0; i< p->num_of_workers; i++) {
lb_sub_worker_t *w =&p->lb_workers[i];
- if (w->sequence< w->s->h.sequence) {
+ if (w->sequence> w->s->h.sequence) {
That's not correct.
The shared memory needs to get incremented on change
and heap memory updated when its sequence is behind
the shared memory. It is illegal to have heap memory
'newer' then the content of shared memory.
But that change was in the push function. So heap *is* newer than shared
and wants to update shared because of that. I agree with the OP that it
should be ">" instead of "<" here. The other changes in r1302479 look OK
to me, but that line consitutes a bug in itself independent of lb_mult
updating. It should prohibit publishing changes of lb member attributes
done via the status worker during runtime at least when under load the
other processes had already pulled the previous state (might not occur
when only clicking a few times).
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
