[ https://issues.apache.org/jira/browse/MTOMCAT-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231914#comment-13231914 ]
patrick garcia edited comment on MTOMCAT-124 at 3/19/12 9:37 PM: ----------------------------------------------------------------- After applying the patch on tomcat-maven-plugin checkout ther is the folloing change to do: to make all pom.xml consistent, it is necessary to remove "<name>test-api-impl</name>" from line 13 on file : tomcat-maven-archetype\src\main\resources\archetype-resources\__rootArtifactId__-api-impl\pom.xml was (Author: patrick123): After applying the patch on tomcat-maven-plugin checkout ther is the folloing change to do: to make all pom.xml consistent, it is necessary to remove "<name>test-api-impl</name>" from line 31 on file : tomcat-maven-archetype\src\main\resources\archetype-resources\__rootArtifactId__-api-impl\pom.xml > tomcat-maven-archetype unused generation parameters > --------------------------------------------------- > > Key: MTOMCAT-124 > URL: https://issues.apache.org/jira/browse/MTOMCAT-124 > Project: Apache Tomcat Maven Plugin > Issue Type: Improvement > Affects Versions: 2.0-beta-1 > Reporter: patrick garcia > Assignee: Olivier Lamy > Priority: Trivial > Labels: archetype, maven, tomcat > Fix For: 2.0 > > Attachments: MTOMCAT-124-tomcat-maven-archetype.patch > > > I found several problems on the superb and very useful > "tomcat-maven-archetype" > The improvement I propos are the followings: > 1/ > "groupId" and "version" can have default values but should be prompt for user > value the same way as for "version" of > "org.apache.maven.archetypes:maven-archetype-quickstart:1.1" > "org.apache.maven.archetypes:maven-archetype-quickstart:1.1" proposes a > default "version" and prompt the user for modification at the same time. > Pressing enter validate the default value. > 2/ > Following variables are not in used: > artifactId-api > artifactId-api-impl > artifactId-webapp > artifactId-webapp-exec > artifactId-webapp-it > This variables should impact the "mvn archetype:generate" behaviour > 3/ > I propos to change the default values of : > artifactId-api = ${artifactId}-api > artifactId-api-impl = ${artifactId}-api-impl > artifactId-webapp = ${artifactId}-webapp > artifactId-webapp-exec = ${artifactId}-webapp-exec > artifactId-webapp-it = ${artifactId}-webapp-it > 4/ > rootArtifactId cat be renamed as artifactId with no default value > I will propos patches for this later. I, first, have to understand > "archetype" framework. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org