Author: markt
Date: Fri Mar 9 20:08:42 2012
New Revision: 1299017
URL: http://svn.apache.org/viewvc?rev=1299017&view=rev
Log:
Filter an issue we can live with. Add comment to code explaining why.
Modified:
tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java?rev=1299017&r1=1299016&r2=1299017&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java Fri Mar 9
20:08:42 2012
@@ -775,6 +775,9 @@ public abstract class ManagerBase extend
do {
if (result != null) {
+ // Not thread-safe but if one of multiple increments is lost
+ // that is not a big deal since the fact that there was any
+ // duplicate is a much bigger issue.
duplicates++;
}
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1299017&r1=1299016&r2=1299017&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Fri Mar 9 20:08:42
2012
@@ -89,6 +89,12 @@
<Bug code="IS" />
</Match>
<Match>
+ <!-- We can live with the threading issue. See code comment for details.
-->
+ <Class name="org.apache.catalina.session.ManagerBase" />
+ <Method name="generateSessionId" />
+ <Bug code="VO" />
+ </Match>
+ <Match>
<!-- Use of null is deliberate -->
<Class name="org.apache.catalina.ssi.ExpressionParseTree" />
<Method name="pushOpp" />
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
