On 02/22/2012 05:52 AM, cos...@apache.org wrote:
Author: costin
+ if (len> TCN_BUFFER_SZ) {
+ return -1;
+ }
Suppose that the len is presumed to always be shorter then 8K.
char * requestedTicket = apr_pcalloc(tcssl->pool, len);
suppose this can be be just
jbyte *requestedTicket = apr_pcalloc(tcssl->pool, len);
so that you don't need to cast later to jbyte*.
+ if (len> TCN_BUFFER_SZ) {
+ return -1;
+ }
should be 'if (len > TCN_BUFFER_SZ)'
Could you arrange the code style of this file.
I mean it uses tabs instead spaces, doesn't have spaces between operators,
C++ comments and so on.
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
