Author: markt
Date: Wed Feb  8 14:33:23 2012
New Revision: 1241909

URL: http://svn.apache.org/viewvc?rev=1241909&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52591
Skip attributes where getters throw UnsupportedOperationException

Modified:
    tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java

Modified: tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java?rev=1241909&r1=1241908&r2=1241909&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java (original)
+++ tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java Wed Feb  8 
14:33:23 2012
@@ -20,6 +20,7 @@ import java.lang.reflect.Array;
 import java.util.Iterator;
 import java.util.Set;
 
+import javax.management.JMRuntimeException;
 import javax.management.MBeanAttributeInfo;
 import javax.management.MBeanInfo;
 import javax.management.MBeanServer;
@@ -79,10 +80,20 @@ public class MBeanDumper {
 
                     try {
                         value=mbeanServer.getAttribute(oname, attName);
+                    } catch (JMRuntimeException rme) {
+                        Throwable cause = rme.getCause();
+                        if (cause instanceof UnsupportedOperationException) {
+                            log.debug("Error getting attribute " + oname +
+                                    " " + attName, rme);
+                        } else {
+                            log.error("Error getting attribute " + oname +
+                                    " " + attName, rme);
+                        }
+                        continue;
                     } catch (Throwable t) {
                         ExceptionUtils.handleThrowable(t);
                         log.error("Error getting attribute " + oname +
-                            " " + attName, t);
+                                " " + attName, t);
                         continue;
                     }
                     if (value==null) continue;



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to