https://issues.apache.org/bugzilla/show_bug.cgi?id=51181
--- Comment #30 from Mark Thomas <ma...@apache.org> 2012-02-08 08:33:37 UTC --- The origin changes look good. I'll incorporate them shortly. Regarding the changes to createWebSocketInbound, I understand passing the protocol but why pass the HttpServletRequest as well? Regarding the changes to the tests, I know we refer to them as unit tests but we frequently test more widely than that to provide greater confidence in the end to end processing chain. Unfortunately, that means we are going to need to write some (very basic) form of WebSocket client to test things. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
