On 03/02/2012 12:19, Konstantin Kolinko wrote:
> 2012/2/3  <ma...@apache.org>:
>> +    @Override
>> +    public String getMBeanKeyProperties() {
>> +        Container c = this;
>> +        StringBuilder keyProperties = new StringBuilder();
>> +        int containerCount = 0;
>> +
>> +        // Work up container hierarchy, add a component to the name for
>> +        // each container
>> +        while (!(c instanceof Engine)) {
>> +            if (c instanceof Wrapper) {
>> +                keyProperties.append(",servlet=");
>> +                keyProperties.append(c.getName());
> 
> I think that the names should be wrapped by ObjectName.quote().
> Here and in similar method implemented in another class below.
> I do not think that there is a restriction that forbids ,;:= in a servlet 
> name.

That is going to change the name Servlets are registered under. That
sort of change has caused problems for folks in the past. I recall
someone (rjung?) fixed a similar issue in the connectors but I can't
remember where or how off-hand.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to