Now finally my vote :)

On 06.01.2012 21:19, Jim Jagielski wrote:
The builds for Tomcat 5.5.35 are ready for testing and approval.
The candidates binaries are available here:

  http://people.apache.org/~jim/tomcat-5.5/

According to the release process, the 5.5.35 build corresponding to the
tag TOMCAT_5_5_35 [1] is:

[ ] Broken
[ ] Alpha
[ ] Beta
[X] Stable
+++

1. http://svn.apache.org/viewvc/tomcat/tc5.5.x/tags/TOMCAT_5_5_35/

- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src mostly consistent with svn tag
- builds fine
- build result looks consistent with binaries
- JMX MBeans only expected change is the new
  maxParameterCount with value 10000, so looks OK

Build was done using Java 1.4.2_19, OS was Solaris 10 Sparc.

- Minor things:

  - STATUS.txt in svn, but not in src tar and zip
    (I guess that's expected)

  - 4 errors in run-tester, same as for 5.5.32-34 (details see below)

  - Some additional javadoc warnings (same as 5.5.32-34 plus 6 new)
    but TC 5.5 was never 100% clean for javadoc (details see below)

Details for run-tester:

   [tester] FAIL [GET /tester/ErrorPage08?type=Arithmetic HTTP/1.0]
Expected data 'ErrorPage06 PASSED - SERVLET', got data 'ErrorPage06
FAILED - message is not correct'
   [tester] FAIL [GET /tester/WrappedErrorPage08?type=Arithmetic
HTTP/1.0] Expected data 'ErrorPage06 PASSED - SERVLET', got data
'ErrorPage06 FAILED - message is not correct'
   [tester] FAIL [GET /tester/ErrorPage08?type=Array HTTP/1.0] Expected
data 'ErrorPage06 PASSED - JSP', got data 'ErrorPage06 FAILED - message
is not correct'
   [tester] FAIL [GET /tester/WrappedErrorPage08?type=Array HTTP/1.0]
Expected data 'ErrorPage06 PASSED - JSP', got data 'ErrorPage06 FAILED -
message is not correct'


Details for Javadoc:

6 new warnings:

.../container/catalina/src/share/org/apache/catalina/connector/Request.java:941: warning - Tag @link: reference not found: Globals.DISPATCHER_TYPE_ATTR .../container/catalina/src/share/org/apache/catalina/connector/Request.java:941: warning - Tag @link: reference not found: Globals.DISPATCHER_REQUEST_PATH_ATTR .../container/catalina/src/share/org/apache/catalina/connector/Request.java:941: warning - Tag @link: reference not found: Globals.CERTIFICATES_ATTR .../container/catalina/src/share/org/apache/catalina/connector/Request.java:941: warning - Tag @link: reference not found: Globals.CIPHER_SUITE_ATTR .../container/catalina/src/share/org/apache/catalina/connector/Request.java:941: warning - Tag @link: reference not found: Globals.KEY_SIZE_ATTR .../container/catalina/src/share/org/apache/catalina/connector/Request.java:941: warning - Tag @link: reference not found: Globals.SSL_SESSION_ID_ATTR

4 old warnings:

.../connectors/util/java/org/apache/tomcat/util/http/Cookies.java:566: warning - Tag @link: can't find getTokenEndPosition(byte[], int, int, boolean) in org.apache.tomcat.util.http.Cookies .../container/catalina/src/share/org/apache/catalina/authenticator/FormAuthenticator.java:315: warning - End Delimiter } missing for possible See Tag in comment string: "If the forward to the login page fails and the call .../container/catalina/src/share/org/apache/catalina/authenticator/FormAuthenticator.java:344: warning - End Delimiter } missing for possible See Tag in comment string: "If the forward to the error page fails and the call .../container/catalina/src/share/org/apache/catalina/connector/Request.java:2239: warning - @param argument "session" is not a parameter name.


Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to