Author: jim
Date: Fri Jan 6 13:50:18 2012
New Revision: 1228185
URL: http://svn.apache.org/viewvc?rev=1228185&view=rev
Log:
* Reduce log level for the message about hitting maxParameterCount limit
from WARN to INFO.
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/http/Parameters.java
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1228185&r1=1228184&r2=1228185&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Fri Jan 6 13:50:18 2012
@@ -24,18 +24,6 @@ $Id$
PATCHES ACCEPTED TO BACKPORT FROM TRUNK/OTHER:
[ start all new proposals below, under PATCHES PROPOSED. ]
-* Reduce log level for the message about hitting maxParameterCount limit
- from WARN to INFO.
- in /connectors/util/java/org/apache/tomcat/util/http/Parameters.java line
243:
- - log.warn(sm.getString("parameters.maxCountFail",
- + log.info(sm.getString("parameters.maxCountFail",
- (backport of http://svn.apache.org/viewvc?rev=1224665&view=rev)
- +1: kkolinko, rjung, jim (w/ ">" change)
- -1:
- rjung: Why do we compare "parameterCount >= limit" in line 241?
- Shouldn't it be ">"?
- kkolinko: I agree, it must be changed to "> limit".
-
PATCHES PROPOSED TO BACKPORT:
[ New proposals should be added at the end of the list ]
Modified:
tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/http/Parameters.java
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/http/Parameters.java?rev=1228185&r1=1228184&r2=1228185&view=diff
==============================================================================
---
tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/http/Parameters.java
(original)
+++
tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/http/Parameters.java
Fri Jan 6 13:50:18 2012
@@ -238,9 +238,9 @@ public final class Parameters {
while(pos < end) {
parameterCount ++;
- if (limit > -1 && parameterCount >= limit) {
+ if (limit > -1 && parameterCount > limit) {
parseFailed = true;
- log.warn(sm.getString("parameters.maxCountFail",
+ log.info(sm.getString("parameters.maxCountFail",
Integer.toString(limit)));
break;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
