https://issues.apache.org/bugzilla/show_bug.cgi?id=52353
--- Comment #2 from Mohsen Vakilian <reprogram...@gmail.com> 2011-12-24 00:21:24 UTC --- Thanks for reviewing this issue. Keshmesh <http://keshmesh.cs.illinois.edu/> detected this problem when we marked method "org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.run()" as an entry point and ran Keshmesh on Tomcat. Keshmesh considers the method "Runnable.run()" as an indicator of possible concurrency. Of course, "Runnable.run()" may not be ever used in a concurrent context, as seems to be the case here. It's good to know that interceptors are not supposed to be configured on the fly. We'd be happy to run Keshmesh on other concurrent parts of Tomcat. Keshmesh analyzes the code that is reachable from the methods that we mark as entry points. Given your deep knowledge of the Tomcat code base, you know better which part of Tomcat is more likely to benefit from Keshmesh. Do you know of other concurrent parts of Tomcat that might benefit from Keshmesh analyses more? By the way, if you use Eclipse, you can try out Keshmesh yourself. We'd love to hear your feedback on it. (In reply to comment #1) > Also, interceptors (and the cluster generally) are not intended to be > configured on the fly. If they were, there is a heap of concurrency issues > that > would need to be fixed. Note: on the fly addition and removal of cluster > members is handled. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
